Generate HasPrincipalKey on relationship if necessary #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBoone
commented
May 23, 2024
| var primaryKeys = relationship.PrimaryProperties; | ||
| var nonPrimaryPrincipalKey = !primaryKeys | ||
| .Select(pp => relationship.PrimaryEntity.Properties.ByProperty(pp.PropertyName)) | ||
| .All(p => p.IsPrimaryKey ?? true); |
There was a problem hiding this comment.
Unsure what IsPrimaryKey == null would mean, so I used ?? true so it would not generate the .HasPrincipalKey stuff in that case. There may be other corner-cases I haven't considered as well.
DavidBoone
force-pushed
the
574-nonPrimaryPrincipalKey
branch
from
4c66530 to
e77c93c
Compare
…ncipalKey on relationshipo
DavidBoone
force-pushed
the
574-nonPrimaryPrincipalKey
branch
from
e77c93c to
7ce664a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a crack at fixing #574 and came up with this.
It resolved the issue I was having with my SQLite test case, but I'm not super familiar with the code-base so I can't be confident it's the right solution in all cases. Please review carefully!
If nothing else I hope it serves as a handy starting point for a more robust implementation.